Thread (139 messages) 139 messages, 5 authors, 2021-04-30

Re: [PATCH 04/30] subtree: t7900: use consistent formatting

From: Luke Shumaker <hidden>
Date: 2021-04-23 22:54:10

On Fri, 23 Apr 2021 15:51:53 -0600,
Eric Sunshine wrote:
On Fri, Apr 23, 2021 at 3:43 PM Luke Shumaker [off-list ref] wrote:
quoted
The formatting in t7900-subtree.sh isn't even consistent throughout the
file.  Fix that; make it consistent throughout the file.

Signed-off-by: Luke Shumaker <redacted>
---
diff --git a/contrib/subtree/t/t7900-subtree.sh b/contrib/subtree/t/t7900-subtree.sh
@@ -23,26 +21,24 @@ subtree_test_create_repo()
-check_equal()
-{
+check_equal () {
        test_debug 'echo'
        test_debug "echo \"check a:\" \"{$1}\""
        test_debug "echo \"      b:\" \"{$2}\""
-       if [ "$1" = "$2" ]; then
+       if [ "$1" = "$2" ]
+       then
We prefer `test` over `[`, so it might make sense to update that, as
well, along with these other style cleanups.
OK, I'll include that in this commit.

-- 
Happy hacking,
~ Luke Shumaker
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help