Thread (41 messages) flat view 41 messages, 3 authors, 2021-02-10

Re: [PATCH 0/7][Outreachy] Improve the 'fixup [-C | -c]' in interactive rebase

From: Charvi Mendiratta <hidden>
Date: 2021-02-08 04:32:48

On Mon, 8 Feb 2021 at 00:28, Eric Sunshine [off-list ref] wrote:
On Sun, Feb 7, 2021 at 1:18 PM Charvi Mendiratta [off-list ref] wrote:
quoted
This patch series is build on the top of "cm/rebase-i" in the 'next' branch and
improves it. It fixup the source code of 'fixup [-C | -c]' command in the
sequencer, do some fixes in rebase -i, improves the 'fixup_-C' like commands
in lib-rebase.sh, update the test-script 't3437' and fixes a typo in the
documentation.
Thanks for working on this. I looked over the entire series and left a
few minor comments. As mentioned in my [6/7] review, you might also
want to consider splitting that patch into several patches (though
it's not clear if the extra work of doing so is warranted). Anyhow,
aside from some botched indentation in [6/7], it all looked clean.
Thanks for the corrections. I admit there are few silly mistakes, will
fixup all and
also split [6/7] in the next version.

Thanks and Regards,
Charvi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help