Re: [PATCH 5/7] t3437: fix indendation of the here-doc
From: Charvi Mendiratta <hidden>
Date: 2021-02-08 04:32:06
On Mon, 8 Feb 2021 at 00:24, Eric Sunshine [off-list ref] wrote:
On Sun, Feb 7, 2021 at 1:19 PM Charvi Mendiratta [off-list ref] wrote:quoted
In the test scripts, the here-doc body and EOF are indented the same amount as the command which opened the here-doc. Let's remove one level of indendation.s/indendation/indentation/
My spelling mistake, I will fix it.
I found "In the test scripts" ambiguous. It isn't clear if you are
talking about all test scripts or the script(s) this patch is fixing
up. Sp, if you happen to re-roll for some reason, perhaps clarify by
saying something like:
The most common way to format here-docs in Git test scripts is for
the body and EOF to be indented the same amount as the command
which opened the here-doc. Fix a few here-docs in this script to
conform to that standard.Okay, will change in the above way.
quoted
Original-patch-by: Phillip Wood [off-list ref]I don't think this new patch is based upon Phillip's, so you can probably drop this attribution.
Okay, thanks.