Thread (41 messages) flat view 41 messages, 3 authors, 2021-02-10

Re: [PATCH 3/7] rebase -i: clarify and fix 'fixup -c' rebase-todo help

From: Eric Sunshine <hidden>
Date: 2021-02-07 18:50:51

On Sun, Feb 7, 2021 at 1:19 PM Charvi Mendiratta [off-list ref] wrote:
When `-c` says "edit the commit message" it's not clear what will be
edited. The original's commit message or the replacement's message or a
combination of the two. Word it such that it states more precisely what
exactly will be edited and also remove the use of a period and
capitalized word in the to-do help text.
If you happen to re-roll for some reason, it might be a good idea to
explain why you are removing the period and capitalization since the
reason is not otherwise clear to the casual reader. So, perhaps:

    ... exactly will be edited. While at it, also drop the jarring
    period and capitalization, neither of which is otherwise present
    in the message.

or something like that.
Signed-off-by: Charvi Mendiratta <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help