Thread (83 messages) 83 messages, 3 authors, 2021-01-30

Re: [PATCH v3 0/7] teach `worktree list` verbose mode and prunable annotations

flat view

From: Eric Sunshine <hidden>
Date: 2021-01-30 09:08:33

On Wed, Jan 27, 2021 at 3:03 AM Rafael Silva
[off-list ref] wrote:
Changes in v4
 * Added documentation to explain that the lock reason is quoted with
   the same rules as described for `core.quotePath`.
 * The `worktree unlock` issued in the test cleanup is splitted and
   executed after each `worktree lock` to ensure the unlock is only
   done after we know each locked command was successful.
 * Fix a couple of grammos in the [4/7] commit message.
I just gave v4 a complete read-through and it looks great. All review
comments on previous rounds have been addressed, and I didn't find
anything important to comment on in v4. Very nicely done.

Please consider this entire series:

    Reviewed-by: Eric Sunshine [off-list ref]

Junio: Perhaps the summary of this series in the merge message can be
refined a bit, as it only talks about verbose mode, but this series
does a bit more than that. Heres a proposal:

    `git worktree list` now annotates worktrees as prunable, shows
    locked and prunable attributes in --porcelain mode, and gained
    a --verbose option.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help