Thread (83 messages) 83 messages, 3 authors, 2021-01-30

Re: [PATCH v3 4/7] t2402: ensure locked worktree is properly cleaned up

flat view

From: Eric Sunshine <hidden>
Date: 2021-01-24 07:52:23

On Tue, Jan 19, 2021 at 4:28 PM Rafael Silva
[off-list ref] wrote:
In c57b3367be (worktree: teach `list` to annotate locked worktree,
2020-10-11) introduced a new test to ensure locked worktrees are listed
with "locked" annotation. However, the test does not clean up after
itself as "git worktree prune" is not going to remove the locked worktree
in the first place. This not only leaves the test in an unclean state it
also potentially breaks following tests that relies on the
"git worktree list" output.
A couple grammos:

1) Drop "In" from the start of the first sentence.
2) s/relies/rely/

But please do not re-roll just for this. It's good enough as-is.

The patch itself is fine.
Let's fix that by unlocking the worktree before the "prune" command.

Helped-by: Eric Sunshine [off-list ref]
Signed-off-by: Rafael Silva <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help