Re: [PATCH 0/7] teach `worktree list` verbose mode and prunable annotations
flat view
From: Eric Sunshine <hidden>
Date: 2021-01-08 08:20:08
On Fri, Jan 8, 2021 at 2:38 AM Rafael Silva [off-list ref] wrote:
Eric Sunshine writes:quoted
On Mon, Jan 4, 2021 at 11:22 AM Rafael Silva [off-list ref] wrote:quoted
The fifth patch adds worktree_escape_reason() that accepts a (char *) text and returned the text with any LF or CRLF escaped. [...]Perhaps I misunderstand, but I had envisioned employing one of the codebase's existing quoting/escaping functions rather than crafting a new one from scratch. However, I'll reserve judgment until I actually read the patch.Agreed. It make sense to reuse one of the already implemented functions from the code base. for some reason I was not able to find it. I believe this was cleared out in one of the patches replies by you and Phillip Wood.
No need to apologize. It's a big project and it can be difficult to discover existing utility functions. Fortunately, reviewers can often point out useful alternatives.