Thread (13 messages) flat view 13 messages, 3 authors, 2021-01-30

Re: [PATCH v4 4/7] bisect--helper: use `res` instead of return in BISECT_RESET case option

From: Christian Couder <hidden>
Date: 2021-01-29 07:59:05

On Mon, Jan 25, 2021 at 8:17 PM Miriam Rubio [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -1043,7 +1043,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
        case BISECT_RESET:
                if (argc > 1)
                        return error(_("--bisect-reset requires either no argument or a commit"));
-               return !!bisect_reset(argc ? argv[0] : NULL);
+               res = bisect_reset(argc ? argv[0] : NULL);
                break;
This "break;" was not necessary before but it becomes necessary when
the above "return ..." is replaced with something else.
        case CHECK_AND_SET_TERMS:
                if (argc != 3)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help