Re: [PATCH v4 3/7] bisect--helper: retire `--bisect-write` subcommand
From: Christian Couder <hidden>
Date: 2021-01-29 07:55:35
On Mon, Jan 25, 2021 at 8:17 PM Miriam Rubio [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -1048,11 +1044,6 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) if (argc > 1) return error(_("--bisect-reset requires either no argument or a commit")); return !!bisect_reset(argc ? argv[0] : NULL);
Here we are returning so we never fall back into the BISECT_WRITE case below...
quoted hunk ↗ jump to hunk
- case BISECT_WRITE: - if (argc != 4 && argc != 5) - return error(_("--bisect-write requires either 4 or 5 arguments")); - set_terms(&terms, argv[3], argv[2]); - res = bisect_write(argv[0], argv[1], &terms, nolog); break;
...so the above "break;" could be removed too.
case CHECK_AND_SET_TERMS:
if (argc != 3)