Thread (13 messages) flat view 13 messages, 3 authors, 2021-01-30

Re: [PATCH v4 2/7] bisect--helper: reimplement `bisect_replay` shell function in C

From: Christian Couder <hidden>
Date: 2021-01-29 07:52:46

On Mon, Jan 25, 2021 at 8:17 PM Miriam Rubio [off-list ref] wrote:
+       while ((strbuf_getline(&line, fp) != EOF) && !res){
It looks like a space char is missing between ")" and "{"...
+               res = process_replay_line(terms, &line);
+       }
...but as there is only one line in the {...}, we could just get rid
of the block like this:

       while ((strbuf_getline(&line, fp) != EOF) && !res)
               res = process_replay_line(terms, &line);

Best,
Christian.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help