On Tue, Jan 19, 2021 at 06:00:19PM -0500, Taylor Blau wrote:
quoted
Good catch. It didn't matter until now because nobody relied on having a
NULL entry when no prefix had been added (instead, they always iterated
over prefixes->nr). IMHO that is worth fixing as a separate commit.
Yeah. Even after calling it out as such myself, I promptly forgot it
when preparing the first patch I sent back to Jacob!
I didn't pull it out into its own patch, and rather folded it in to my
2/2. It has a small call-out of its own, but if you'd prefer it by
itself, I'm happy to resubmit it with that change included.
It's not a _huge_ deal to me, but I think it is slightly nicer as a
separate patch. Plus it can easily be credited to Jacob, so at least he
gets some authorship credit out of this. :)
-Peff