Thread (22 messages) 22 messages, 5 authors, 2020-12-03

Re: [PATCH 6/6] fixup! reftable: rest of library

From: Jeff King <hidden>
Date: 2020-12-02 01:51:32

On Tue, Dec 01, 2020 at 03:24:01PM +0100, Johannes Schindelin wrote:
quoted
I don't see it being invoked anywhere,
It is invoked in `t/t0032-reftable-unittest.sh`:
https://github.com/dscho/git/blob/reftable-on-windows/t/t0032-reftable-unittest.sh
Ah, thank you. I was looking at what Junio has queued in hn/reftable.
quoted
but presumably if we were to add support to our test suite, we'd have a
script which invokes it within a scratch directory.
I agree that it would make most sense for t0032 to prefix the call to
`test-tool` with `TMPDIR=$PWD`.
Yep, that would be fine.

I'm not sure if the long-term goal is to have this opaque unit-test
program or not. If it is, I was likewise going to suggest that its
ad-hoc output be replaced with TAP. But it looks like on your branch
that "test-tool reftable" does not produce output at all. So I may be a
bit behind on what the current state and forward plans are...

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help