Thread (22 messages) 22 messages, 5 authors, 2020-12-03

Re: [PATCH 6/6] fixup! reftable: rest of library

From: Jeff King <hidden>
Date: 2020-12-01 10:29:41

On Sat, Nov 28, 2020 at 06:44:38AM +0000, Johannes Schindelin via GitGitGadget wrote:
From: Johannes Schindelin <redacted>

The stack_test hard-codes `/tmp/`. That is a particular problem on
Windows where the temp directory is never at that location.

Let's not do that, but instead use `TMPDIR` as we do in similar
scenarios in the rest of Git's source code.
Yeah, I noticed this, as well. This seems like a good band-aid, but it
would probably be nice if the test tool was able to write into a
specified directory (or even just the current directory). I don't see it
being invoked anywhere, but presumably if we were to add support to our
test suite, we'd have a script which invokes it within a scratch
directory.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help