Thread (22 messages) 22 messages, 5 authors, 2020-12-03

Re: [PATCH 6/6] fixup! reftable: rest of library

From: Johannes Schindelin <hidden>
Date: 2020-12-01 14:25:43

Hi Peff,

On Tue, 1 Dec 2020, Jeff King wrote:
On Sat, Nov 28, 2020 at 06:44:38AM +0000, Johannes Schindelin via GitGitGadget wrote:
quoted
From: Johannes Schindelin <redacted>

The stack_test hard-codes `/tmp/`. That is a particular problem on
Windows where the temp directory is never at that location.

Let's not do that, but instead use `TMPDIR` as we do in similar
scenarios in the rest of Git's source code.
Yeah, I noticed this, as well. This seems like a good band-aid, but it
would probably be nice if the test tool was able to write into a
specified directory (or even just the current directory).
You can force it to do that by setting `TMPDIR` to the path of the current
directory...
I don't see it being invoked anywhere,
It is invoked in `t/t0032-reftable-unittest.sh`:
https://github.com/dscho/git/blob/reftable-on-windows/t/t0032-reftable-unittest.sh
but presumably if we were to add support to our test suite, we'd have a
script which invokes it within a scratch directory.
I agree that it would make most sense for t0032 to prefix the call to
`test-tool` with `TMPDIR=$PWD`.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help