Re: [PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return
From: Shourya Shukla <hidden>
Date: 2020-07-25 17:31:27
From: Shourya Shukla <hidden>
Date: 2020-07-25 17:31:27
Following 'enum bisect_error' vocabulary, return variable 'res' is always non-positive. Let's use '-res' instead of 'abs(res)' to make the code clearer.
Mentored-by: Christian Couder [off-list ref] Signed-off-by: Miriam Rubio <redacted> Helped-by: Junio C Hamano [off-list ref]
Although there is no set rule for this, but I think that your sign-off goes at the last generally. This is what I have seen on various patches.