[PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return
From: Miriam Rubio <hidden>
Date: 2020-07-17 10:54:51
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Miriam Rubio <hidden>
Date: 2020-07-17 10:54:51
Subsystem:
the rest · Maintainer:
Linus Torvalds
Following 'enum bisect_error' vocabulary, return variable 'res' is always non-positive. Let's use '-res' instead of 'abs(res)' to make the code clearer. Mentored-by: Christian Couder [off-list ref] Signed-off-by: Miriam Rubio <redacted> Helped-by: Junio C Hamano [off-list ref] --- builtin/bisect--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index c452d3f6b7..0466b07a43 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c@@ -727,5 +727,5 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) if (res == BISECT_INTERNAL_SUCCESS_MERGE_BASE) res = BISECT_OK; - return abs(res); + return -res; }
--
2.25.0