Re: [PATCH v5 01/13] bisect--helper: BUG() in cmd_*() on invalid subcommand
From: Shourya Shukla <hidden>
Date: 2020-07-25 17:28:04
From: Shourya Shukla <hidden>
Date: 2020-07-25 17:28:04
Hello Miriam,
In cmd_bisect__helper() function, there would be a bug if an invalid or no subcommand was passed.return error() should be replaced by BUG() in that case.
Mentored-by: Christian Couder [off-list ref] Mentored-by: Johannes Schindelin [off-list ref] Signed-off-by: Miriam Rubio <redacted> ---
I think we can try for a better message. Maybe something like:
One encounters a BUG when an invalid or no subcommand is passed to
'cmd_bisect__helper()'. BUG() out instead of returning an error.
- return error("BUG: unknown subcommand '%d'", cmdmode);
+ BUG("unknown subcommand %d", (int)cmdmode);Do we need to typecast an integer to an integer here? Regards, Shourya Shukla