Re: [PATCH 08/15] t0020: s/test_must_fail has_cr/! has_cr/

[PATCH 00/15] t: replace incorrect test_must_fail usage (part 1) · Denton Liu <hidden> · 2019-12-17
[PATCH 01/15] test-lib-functions: introduce test_non_git_might_fail() · Denton Liu <hidden> · 2019-12-17
[PATCH 03/15] t0000: replace test_must_fail with ! for run_sub_test_lib_test() · Denton Liu <hidden> · 2019-12-17
Re: [PATCH 03/15] t0000: replace test_must_fail with ! for run_sub_test_lib_test() · Johannes Sixt <hidden> · 2019-12-17
[PATCH 05/15] t0003: use test_must_be_empty() · Denton Liu <hidden> · 2019-12-17
[PATCH 04/15] t0003: use named parameters in attr_check() · Denton Liu <hidden> · 2019-12-17
Re: [PATCH 04/15] t0003: use named parameters in attr_check() · Eric Sunshine <hidden> · 2019-12-17
[PATCH 07/15] t0020: drop redirections to /dev/null · Denton Liu <hidden> · 2019-12-17
Re: [PATCH 07/15] t0020: drop redirections to /dev/null · Eric Sunshine <hidden> · 2019-12-17
[PATCH 06/15] t0003: don't use `test_must_fail attr_check` · Denton Liu <hidden> · 2019-12-17
[PATCH 08/15] t0020: s/test_must_fail has_cr/! has_cr/ · Denton Liu <hidden> · 2019-12-17
Re: [PATCH 08/15] t0020: s/test_must_fail has_cr/! has_cr/ · Eric Sunshine <hidden> · 2019-12-17
[PATCH 11/15] t1307: reorder `nongit test_must_fail` · Denton Liu <hidden> · 2019-12-17
[PATCH 10/15] t1306: convert `test_might_fail rm` to `rm -f` · Denton Liu <hidden> · 2019-12-17
[PATCH 09/15] t0020: use ! check_packed_refs_marked · Denton Liu <hidden> · 2019-12-17
[PATCH 13/15] t1409: use test_path_is_missing() · Denton Liu <hidden> · 2019-12-17
[PATCH 14/15] t1501: remove use of `test_might_fail cp` · Denton Liu <hidden> · 2019-12-17
Re: [PATCH 14/15] t1501: remove use of `test_might_fail cp` · Eric Sunshine <hidden> · 2019-12-17
[PATCH 15/15] t1507: teach full_name() to accept `!` arg · Denton Liu <hidden> · 2019-12-17
Re: [PATCH 15/15] t1507: teach full_name() to accept `!` arg · Eric Sunshine <hidden> · 2019-12-17
[PATCH 12/15] t1409: let sed open its own files · Denton Liu <hidden> · 2019-12-17
[PATCH 02/15] t/lib-git-p4: use test_path_is_missing() · Denton Liu <hidden> · 2019-12-17
[PATCH v2 00/16] t: replace incorrect test_must_fail usage (part 1) · Denton Liu <hidden> · 2019-12-19
[PATCH v2 01/16] test-lib-functions: introduce test_non_git_might_fail() · Denton Liu <hidden> · 2019-12-19
[PATCH v2 02/16] t/lib-git-p4: use test_path_is_missing() · Denton Liu <hidden> · 2019-12-19
[PATCH v2 06/16] t0003: don't use `test_must_fail attr_check` · Denton Liu <hidden> · 2019-12-19
[PATCH v2 07/16] t0020: don't use `test_must_fail has_cr` · Denton Liu <hidden> · 2019-12-19
[PATCH v2 04/16] t0003: use named parameters in attr_check() · Denton Liu <hidden> · 2019-12-19
[PATCH v2 03/16] t0000: replace test_must_fail with run_sub_test_lib_test_err() · Denton Liu <hidden> · 2019-12-19
[PATCH v2 10/16] t1307: reorder `nongit test_must_fail` · Denton Liu <hidden> · 2019-12-19
[PATCH v2 11/16] t1409: let sed open its own input file · Denton Liu <hidden> · 2019-12-19
[PATCH v2 12/16] t1409: use test_path_is_missing() · Denton Liu <hidden> · 2019-12-19
[PATCH v2 09/16] t1306: convert `test_might_fail rm` to `rm -f` · Denton Liu <hidden> · 2019-12-19
[PATCH v2 08/16] t0020: use ! check_packed_refs_marked · Denton Liu <hidden> · 2019-12-19
[PATCH v2 05/16] t0003: use test_must_be_empty() · Denton Liu <hidden> · 2019-12-19
[PATCH v2 13/16] t1501: remove use of `test_might_fail cp` · Denton Liu <hidden> · 2019-12-19
Re: [PATCH v2 13/16] t1501: remove use of `test_might_fail cp` · Eric Sunshine <hidden> · 2019-12-19
Re: [PATCH v2 13/16] t1501: remove use of `test_might_fail cp` · Denton Liu <hidden> · 2019-12-19
Re: [PATCH v2 13/16] t1501: remove use of `test_might_fail cp` · Eric Sunshine <hidden> · 2019-12-20
[PATCH v2 14/16] t1507: stop losing return codes of git commands · Denton Liu <hidden> · 2019-12-19
[PATCH v2 16/16] t1507: inline full_name() · Denton Liu <hidden> · 2019-12-19
[PATCH v2 15/16] t1507: run commands within test_expect_success · Denton Liu <hidden> · 2019-12-19
[PATCH v3 00/15] t: replace incorrect test_must_fail usage (part 1) · Denton Liu <hidden> · 2019-12-20
[PATCH v3 01/15] t/lib-git-p4: use test_path_is_missing() · Denton Liu <hidden> · 2019-12-20
[PATCH v3 02/15] t0000: replace test_must_fail with run_sub_test_lib_test_err() · Denton Liu <hidden> · 2019-12-20
[PATCH v3 03/15] t0003: use named parameters in attr_check() · Denton Liu <hidden> · 2019-12-20
[PATCH v3 04/15] t0003: use test_must_be_empty() · Denton Liu <hidden> · 2019-12-20
[PATCH v3 06/15] t0020: don't use `test_must_fail has_cr` · Denton Liu <hidden> · 2019-12-20
[PATCH v3 05/15] t0003: don't use `test_must_fail attr_check` · Denton Liu <hidden> · 2019-12-20
[PATCH v3 08/15] t1306: convert `test_might_fail rm` to `rm -f` · Denton Liu <hidden> · 2019-12-20
[PATCH v3 07/15] t0020: use ! check_packed_refs_marked · Denton Liu <hidden> · 2019-12-20
[PATCH v3 11/15] t1409: use test_path_is_missing() · Denton Liu <hidden> · 2019-12-20
[PATCH v3 10/15] t1409: let sed open its own input file · Denton Liu <hidden> · 2019-12-20
[PATCH v3 12/15] t1501: remove use of `test_might_fail cp` · Denton Liu <hidden> · 2019-12-20
[PATCH v3 13/15] t1507: stop losing return codes of git commands · Denton Liu <hidden> · 2019-12-20
[PATCH v3 09/15] t1307: reorder `nongit test_must_fail` · Denton Liu <hidden> · 2019-12-20
[PATCH v3 14/15] t1507: run commands within test_expect_success · Denton Liu <hidden> · 2019-12-20
[PATCH v3 15/15] t1507: inline full_name() · Denton Liu <hidden> · 2019-12-20

From: Eric Sunshine <hidden>
Date: 2019-12-17 19:36:33

On Tue, Dec 17, 2019 at 7:02 AM Denton Liu [off-list ref] wrote:

t0020: s/test_must_fail has_cr/! has_cr/

Cryptic patch subject. How about being consistent with other patch
subjects in this series?

    t0020: don't use `test_must_fail has_cr`

The test_must_fail function should only be used for git commands since
we should assume that external commands work sanely. Since has_cr() just
wraps a tr and grep pipeline, replace `test_must_fail has_cr` with
`! has_cr`.

Signed-off-by: Denton Liu <redacted>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help