[PATCH 02/15] t/lib-git-p4: use test_path_is_missing()
From: Denton Liu <hidden>
Date: 2019-12-17 12:02:01
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Denton Liu <hidden>
Date: 2019-12-17 12:02:01
Subsystem:
the rest · Maintainer:
Linus Torvalds
Previously, cleanup_git() would use `test_must_fail test -d` to ensure that the directory is removed. However, test_must_fail should only be used for git commands. Use test_path_is_missing() instead to check that the directory has been removed. Signed-off-by: Denton Liu <redacted> --- t/lib-git-p4.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
index 547b9f88e1..5aff2abe8b 100644
--- a/t/lib-git-p4.sh
+++ b/t/lib-git-p4.sh@@ -175,7 +175,7 @@ stop_and_cleanup_p4d () { cleanup_git () { retry_until_success rm -r "$git" - test_must_fail test -d "$git" && + test_path_is_missing "$git" && retry_until_success mkdir "$git" }
--
2.24.0.627.geba02921db