Re: [PATCH v2 01/10] t/test-lib: teach --chain-lint to detect broken &&-chains in subshells

On Thu, Aug 23, 2018 at 2:02 PM Ævar Arnfjörð Bjarmason
[off-list ref] wrote:

Found in some 2.19 testing on AIX:

Thanks for reporting these issues.

quoted

+     /^[     ]*EOF[  ]*$/!bhereslurp

AIX sed doesn't like this, and will yell:
    :hereslurp is greater than eight characters
This on top fixes it:

Fix make sense, and checking POSIX[1] , I see that it says that
behavior is unspecified for labels longer than 8 bytes.

[1]: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html

quoted

+# bare "(" line?
+/^[  ]*([    ]*$/ {
+     # stash for later printing

AIX sed doesn't like this either, and prints:
    sed:    # stash for later printing is not a recognized function.
I have no idea what the fix is for that one.

That's the only indented comment in the entire script, so it's almost
certainly that. How about we move the indented comment up to the
comment for the enclosing block, so it reads:

    # bare "(" line? -- stash for later printing
    /^[  ]*([    ]*$/ {
        h
        bnextline
    }

I could prepare such a patch, although perhaps it would be better for
you to do so since you are in a position to test it (and because you
discovered the problems)?