Re: [PATCH 17/29] t: use test_must_fail() instead of checking exit code manually

Am 26.06.2018 um 20:14 schrieb Eric Sunshine:

On Tue, Jun 26, 2018 at 2:06 PM Johannes Sixt [off-list ref] wrote:

quoted

Hence, these lines should actually be

                 p4 help client &&
                 ! p4 help nosuchcommand

Thanks for the comment; you're right, of course. I'll certainly make
this change if I have to re-roll for some other reason, but do you
feel that this itself is worth a re-roll?

Not worth a re-roll IMO.

-- Hannes