Re: [PATCH] t/lib-submodule-update: fix absorbing test

On Wed, Jun 27, 2018 at 2:31 PM Stefan Beller [off-list ref] wrote:

From: Eric Sunshine <redacted>

This test has been dysfunctional since it was added by 259f3ee296
(lib-submodule-update.sh: define tests for recursing into submodules,
2017-03-14), however, problems went unnoticed due to a broken &&-chain
toward the end of the test.
[...]
Signed-off-by: Eric Sunshine <redacted>
Signed-off-by: Stefan Beller <redacted>
---
In an ideal world the commands would not fail, but absorb the git directory
of the submodule. I manually tested that it is absorbed and not data from
a git directory is lost.

I would propose to replace that patch with the patch below; I hope
the wording did not add more confusion than there is already.

Thanks for diagnosing the problem, Stefan. I'm not a submodule user
and was not at all confident that I had interpreted the test breakage
correctly or that my fix was appropriate, so I'm happy to have a
diagnosis and fix from the person who actually wrote the test.

I'll also add a Helped-by: when re-posting.