Re: [PATCHv3 5/6] compat/precompose_utf8.h: use more common include guard style
From: Jonathan Nieder <hidden>
Date: 2018-08-15 05:28:11
Elijah Newren wrote:
Signed-off-by: Elijah Newren <redacted> --- compat/precompose_utf8.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Jonathan Nieder <redacted> The more unusual style is less likely to be recognized by compilers, so we can waste some I/O re-reading the header at compile time.
quoted hunk ↗ jump to hunk
--- a/compat/precompose_utf8.h +++ b/compat/precompose_utf8.h@@ -1,4 +1,6 @@ #ifndef PRECOMPOSE_UNICODE_H +#define PRECOMPOSE_UNICODE_H + #include <sys/stat.h> #include <sys/types.h> #include <dirent.h>
Not about this patch: these headers are #include-d in git-compat-util.h which we assume to be already included first before anything else. Can we remove these redundant #includes?