Re: [PATCH 0/9] Add missing includes and forward declares
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2018-08-11 08:32:24
On Sat, Aug 11 2018, Elijah Newren wrote: [CC'd sha1dc maintainers, for context the relevent patch is https://public-inbox.org/git/20180811043218.31456-8-newren@gmail.com/T/#u]
* Patches 6-8: These patches might need to be submitted to separate
projects elsewhere. Let me know if so.
Yes, for sha1dc (your 7/9) it's much better if we submit patches to
upstream and then submit a patch to git.git to update from upstream, as
my 23e37f8e9d ("sha1dc: update from upstream", 2018-08-02) sitting in
'next' does.
When we build that library we define SHA1DC_NO_STANDARD_INCLUDES, so we
don't use the codepath you patched, so your description of "I was bit
yet again by compilation errors[...]" doesn't add up in that case. I
assume you just started adding stdlib.h where you could grep for
stdint.h.
When I check out sha1collisiondetection.git stand-alone (which will use
that path) and compile it, it works fine for me. This is on GCC 8.1.0 on
Debian, so perhaps that patch isn't needed in that case.