Thread (39 messages) flat view 39 messages, 5 authors, 2018-08-15

Re: [PATCHv3 4/6] urlmatch.h: fix include guard

From: Jonathan Nieder <hidden>
Date: 2018-08-15 05:25:32

Elijah Newren wrote:
Signed-off-by: Elijah Newren <redacted>
---
 urlmatch.h | 2 ++
 1 file changed, 2 insertions(+)
Reviewed-by: Jonathan Nieder <redacted>

This has two benefits:

- avoids the definitions in this header from being evaluated twice

- many compilers recognize the #include guard idiom and also are able
  to avoid re-reading the text of the header twice, too

The header guard had been broken since day one.  Is there a tool that
can detect this class of problem?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help