Re: [PATCH v4 05/21] range-diff: also show the diff between patches

Hi Eric,

On Fri, 10 Aug 2018, Eric Sunshine wrote:

On Fri, Aug 10, 2018 at 5:12 PM Johannes Schindelin
[off-list ref] wrote:

quoted

On Mon, 30 Jul 2018, Eric Sunshine wrote:

quoted

I think you can attain the desired behavior by making a final
parse_options() call with empty 'options' list after the call to
diff_setup_done(). It's pretty much a one-line fix, but can probably
be done as an incremental change rather than rerolling.

But then we would have to keep `--` in the first, and not in the second
parse_options() call, right? We would also have to handle that `--`
properly in the loop that calls diff_opt_parse(), I think.
A bit more involved than just a one-line fix, but I guess I'll give it a
try.

It's something that could easily wait until after this series lands.
After all, it's just a slightly confusing error message, not some
fundamental problem.

As for '--', I'll have to go back and look at the code. I thought I
had thought it all through at the time I made the suggestion, but my
brain needs a refresh by now.

Your suggestion might have started out by trying to fix the error message,
but after staring at the code for a couple of minutes, I think the issue
would have left all kinds of opportunities for bad user experience.

So I fixed it ;-)

Ciao,
Dscho