Re: [PATCH v4 10/21] range-diff: do not show "function names" in hunk headers

Hi Thomas,

On Sun, 29 Jul 2018, Thomas Gummerer wrote:

On 07/21, Johannes Schindelin via GitGitGadget wrote:

quoted

From: Johannes Schindelin <redacted>

We are comparing complete, formatted commit messages with patches. There
are no function names here, so stop looking for them.

While there are no function names here, trying out range-diff without
this patch applied, the headers were getting here do seem kind of
useful:

    1: 92588fc6b6 ! 3: 43c9ef552c
        @@ -8,8 +8,16 @@ diff --git a/read-cache.c b/read-cache.c
    	[...]

The filename can be quite useful in this output.  I guess this is a
bit brittle though, so I'm also happy to defer changing this to show
something useful to the list of possible future enhancements
(obviously doesn't necessarily have to be implemented by you at that
point).

To be honest, I never thought about this, I just assumed that tbdiff had
good reasons to strip this.

I agree, though, that we (as in: you :-)) can look at this after
`range-diff` lands in `next`.

Ciao,
Dscho