Re: [PATCH v3 20/20] range-diff: make --dual-color the default mode

Hi Eric,

On Mon, 16 Jul 2018, Eric Sunshine wrote:

On Tue, Jul 3, 2018 at 7:26 AM Johannes Schindelin via GitGitGadget
[off-list ref] wrote:

quoted

After using this command extensively for the last two months, this
developer came to the conclusion that even if the dual color mode still
leaves a lot of room for confusion what was actually changed, the

"...confusion _about_ what..."

quoted

non-dual color mode is substantially worse in that regard.

Therefore, we really want to make the dual color mode the default.

Signed-off-by: Johannes Schindelin <redacted>
---

diff --git a/Documentation/git-range-diff.txt b/Documentation/git-range-diff.txt

@@ -31,11 +31,14 @@ all of their ancestors have been shown.
---dual-color::
-       When the commit diffs differ, recreate the original diffs'
-       coloring, and add outer -/+ diff markers with the *background*
-       being red/green to make it easier to see e.g. when there was a
-       change in what exact lines were added.
+--no-dual-color::
+       When the commit diffs differ, `git range-diff` recreates the
+       original diffs' coloring, and add outer -/+ diff markers with

s/add/adds/

quoted

+       the *background* being red/green to make it easier to see e.g.
+       when there was a change in what exact lines were added. This is
+       known to `range-diff` as "dual coloring". Use `--no-dual-color`
+       to revert to color all lines according to the outer diff markers
+       (and completely ignore the inner diff when it comes to color).

Yep, thank you very much!
Dscho