Re: [RFC PATCH v2 01/12] submodule: add a print_config_from_gitmodules() helper

On Thu, 2 Aug 2018 11:05:02 -0700
Stefan Beller [off-list ref] wrote:

On Thu, Aug 2, 2018 at 6:47 AM Antonio Ospite [off-list ref] wrote:

quoted

[...]

quoted

+extern int print_config_from_gitmodules(const char *key);

The only real pushback for this patch I'd have is lack of documentation
in public functions, though this is pretty self explanatory; so I'd be fine
for lacking the docs here.

In case a resend is needed, please drop the extern keyword here.

I'll drop the extern keyword also for the public function added in
patch 02 then.

Thanks,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?