Re: [RFC PATCH v2 11/12] dir: move is_empty_file() from builtin/am.c to dir.c and make it public
From: Stefan Beller <hidden>
Date: 2018-08-02 20:51:08
On Thu, Aug 2, 2018 at 6:47 AM Antonio Ospite [off-list ref] wrote:
The is_empty_file() function can be generally useful, move it to dir.c and make it public. Signed-off-by: Antonio Ospite <redacted>
Makes sense, Thanks, Stefan
quoted hunk ↗ jump to hunk
+++ b/dir.c@@ -2412,6 +2412,22 @@ int is_empty_dir(const char *path) return ret; } +/** + * Returns 1 if the file is empty or does not exist, 0 otherwise. + */
Please move the comment to the header instead. /* possibly as a oneliner ? */