Re: [RFC PATCH v2 11/12] dir: move is_empty_file() from builtin/am.c to dir.c and make it public

On Thu, 2 Aug 2018 13:50:55 -0700
Stefan Beller [off-list ref] wrote:

On Thu, Aug 2, 2018 at 6:47 AM Antonio Ospite [off-list ref] wrote:

quoted

The is_empty_file() function can be generally useful, move it to dir.c
and make it public.

Signed-off-by: Antonio Ospite <redacted>

Makes sense,

Thanks,
Stefan

quoted

+++ b/dir.c

@@ -2412,6 +2412,22 @@ int is_empty_dir(const char *path)
        return ret;
 }

+/**
+ * Returns 1 if the file is empty or does not exist, 0 otherwise.
+ */

Please move the comment to the header instead.
/* possibly as a oneliner ? */

Will do.

Thanks,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?