Re: [PATCH 03/22] builtin/config.c: mark more strings for translation
From: Eric Sunshine <hidden>
Date: 2018-06-03 09:01:14
On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy [off-list ref] wrote:
quoted hunk ↗ jump to hunk
There are also some minor adjustments in the strings. Signed-off-by: Nguyễn Thái Ngọc Duy <redacted> ---diff --git a/builtin/config.c b/builtin/config.c@@ -746,7 +746,7 @@ int cmd_config(int argc, const char **argv, const char *prefix) if (ret == CONFIG_NOTHING_SET) error(_("cannot overwrite multiple values with a single value\n" - " Use a regexp, --add or --replace-all to change %s."), argv[0]); + " Use a regexp, --add or --replace-all to change %s"), argv[0]);
Perhaps?
cannot overwrite multiple values with a single value;
use a regexp, --add or --replace-all to change %s
quoted hunk ↗ jump to hunk
@@ -819,7 +819,7 @@ int cmd_config(int argc, const char **argv, const char *prefix) if (ret == 0) - die("No such section!"); + die(_("no such section!"));@@ -830,7 +830,7 @@ int cmd_config(int argc, const char **argv, const char *prefix) if (ret == 0) - die("No such section!"); + die(_("no such section!"));
In other patches, you dropped the trailing "!"; perhaps do so for
these two also?
Maybe even:
die(_("no such section: %s", whatever);
Though, that may be out of scope of this patch series.