Re: [PATCH 06/22] builtin/replace.c: mark more strings for translation
From: Eric Sunshine <hidden>
Date: 2018-06-03 08:41:32
On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Nguyễn Thái Ngọc Duy <redacted> ---diff --git a/builtin/replace.c b/builtin/replace.c@@ -456,10 +456,10 @@ static int create_graft(int argc, const char **argv, int force, int gentle) - if (remove_signature(&buf)) { - warning(_("the original commit '%s' has a gpg signature."), old_ref); - warning(_("the signature will be removed in the replacement commit!")); - } + if (remove_signature(&buf)) + warning(_("the original commit '%s' has a gpg signature.\n" + "The signature will be removed in the replacement commit!"), + old_ref);
It's kind of weird to drop capitalization of the first sentence but
not the second. Also, you dropped trailing "!" in some other patches;
do you want to do so here? Perhaps, instead:
the original commit '%s' has a gpg signature;
the signature will be removed in the replacement commit