On Sat, Mar 24, 2018 at 8:53 AM, Nguyễn Thái Ngọc Duy [off-list ref] wrote:

The set of extra warnings we enable when DEVELOPER has to be
conservative because we can't assume any compiler version the
developer may use. Detect the compiler version so we know when it's
safe to enable -Wextra and maybe more.

These warning settings are mostly from my custom config.mak a long
time ago when I tried to enable as many warnings as possible that can
still build without showing warnings. Some of them those warnings are

s/them those/those/

probably worth fixing instead of just suppressing in future.

Helped-by: Jeff King [off-list ref]
Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>