On Sun, Mar 18, 2018 at 5:17 AM, Duy Nguyen [off-list ref] wrote:

On Sun, Mar 18, 2018 at 10:06 AM, Eric Sunshine [off-list ref] wrote:

quoted

On MacOS, "cc -v" output is:

--- >8 ---

Apple LLVM version 9.0.0 (clang-900.0.39.2)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: ...

--- >8 ---

Does it still build ok for you with your changes squashed in? I think
the check for clang4/gcc6 and setting -Wextra in config.mak.dev may
backfire because clang9 probably has a lot more warnings enabled and
some of them we don't want and cause compile error...

The project does still compile cleanly for me. (And I used "make V=1"
to verify that the new flags are used.)