Re: [PATCH v2] travis-ci: enable more warnings on travis linux-gcc job
From: Duy Nguyen <hidden>
Date: 2018-03-17 08:02:09
From: Duy Nguyen <hidden>
Date: 2018-03-17 08:02:09
On Fri, Mar 16, 2018 at 10:22 PM, Jeff King [off-list ref] wrote:
quoted
diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh index 3735ce413f..f6f346c468 100755 --- a/ci/run-build-and-tests.sh +++ b/ci/run-build-and-tests.sh@@ -7,6 +7,22 @@ ln -s "$cache_dir/.prove" t/.prove +if [ "$jobname" = linux-gcc ]; then + gcc-6 --version + cat >config.mak <<-EOF + CC=gcc-6 + CFLAGS = -g -O2 -Wall + CFLAGS += -Wextra + CFLAGS += -Wmissing-prototypes + CFLAGS += -Wno-empty-body + CFLAGS += -Wno-maybe-uninitialized + CFLAGS += -Wno-missing-field-initializers + CFLAGS += -Wno-sign-compare + CFLAGS += -Wno-unused-function + CFLAGS += -Wno-unused-parameter + EOF +fiWhy isn't this just turning on DEVELOPER=1 if we know we have a capable compiler?
DEVELOPER=1 is always set even before this patch. It's set and exported in lib-travisci.sh. -- Duy