Thread (61 messages) 61 messages, 5 authors, 2018-02-16

Re: [PATCH v7 18/31] merge-recursive: make a helper function for cleanup for handle_renames

From: Stefan Beller <hidden>
Date: 2018-02-03 00:31:48

On Tue, Jan 30, 2018 at 3:25 PM, Elijah Newren [off-list ref] wrote:
In anticipation of more involved cleanup to come, make a helper function
for doing the cleanup at the end of handle_renames.  Rename the already
existing cleanup_rename[s]() to final_cleanup_rename[s](), name the new
helper initial_cleanup_rename(), and leave the big comment in the code
about why we can't do all the cleanup at once.

Signed-off-by: Elijah Newren <redacted>
This mostly touches new code of the series, so it feels a bit unnecessary.
I don't feel strongly about it being a separate patch, as the patches up to
now are easy to review. (and squashing may harm reviewability)

But the code makes sense.

Stefan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help