Thread (61 messages) 61 messages, 5 authors, 2018-02-16

Re: [PATCH v7 14/31] merge-recursive: fix leaks of allocated renames and diff_filepairs

From: Stefan Beller <hidden>
Date: 2018-02-02 23:41:55

On Tue, Jan 30, 2018 at 3:25 PM, Elijah Newren [off-list ref] wrote:
get_renames() has always zero'ed out diff_queued_diff.nr while only
manually free'ing diff_filepairs that did not correspond to renames.
Further, it allocated struct renames that were tucked away in the
return string_list.  Make sure all of these are deallocated when we
are done with them.

Signed-off-by: Elijah Newren <redacted>
Thanks for spotting the memleaks and fixing them in here.

If this series takes longer to review/cook, this patch
could go in separately? (with the last patch undone :/)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help