Re: [PATCH 9/8] [DO NOT APPLY, but squash?] git-rebase--interactive: clarify arguments
From: Johannes Schindelin <hidden>
Date: 2018-01-18 21:37:05
Hi Stefan, On Thu, 18 Jan 2018, Stefan Beller wrote:
quoted hunk ↗ jump to hunk
Up to now each command took a commit as its first argument and ignored the rest of the line (usually the subject of the commit) Now that we have commands that take different arguments, clarify each command by giving the argument list. Signed-off-by: Stefan Beller <redacted> --- git-rebase--interactive.sh | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 23184c77e8..3cd7446d0b 100644 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh@@ -155,17 +155,17 @@ reschedule_last_action () { append_todo_help () { gettext " Commands: -p, pick = use commit -r, reword = use commit, but edit the commit message -e, edit = use commit, but stop for amending -s, squash = use commit, but meld into previous commit -f, fixup = like \"squash\", but discard this commit's log message -x, exec = run command (the rest of the line) using shell -d, drop = remove commit -l, label = label current HEAD with a name -t, reset = reset HEAD to a label -b, bud = reset HEAD to the revision labeled 'onto' -m, merge = create a merge commit using a given commit's message +p, pick <commit> = use commit +r, reword <commit> = use commit, but edit the commit message +e, edit <commit> = use commit, but stop for amending +s, squash <commit> = use commit, but meld into previous commit +f, fixup <commit> = like \"squash\", but discard this commit's log message +x, exec <commit> = run command (the rest of the line) using shell +d, drop <commit> = remove commit +l, label <label>= label current HEAD with a name +t, reset <label> = reset HEAD to a label +b, bud = reset HEAD to the revision labeled 'onto', no arguments +m, merge [<label-or-commit>]* = create a merge commit using a given commit's message
Good idea! I would rather do it as an introductory patch (that only converts the existing list). As to `merge`: it is a bit more complicated ;-) m, merge <original-merge-commit> ( <label> | "<label>..." ) [<oneline>] create a merge commit using the original merge commit's message (or the oneline, if "-" is given). Use a quoted list of commits to be merged for octopus merges. Thanks, Dscho