Re: [PATCH 1/8] sequencer: introduce new commands to reset the revision
From: Jacob Keller <hidden>
Date: 2018-01-18 16:26:03
From: Jacob Keller <hidden>
Date: 2018-01-18 16:26:03
On Thu, Jan 18, 2018 at 7:35 AM, Johannes Schindelin [off-list ref] wrote:
This commit implements the commands to label, and to reset to, given
revisions. The syntax is:
label <name>
reset <name>
As a convenience shortcut, also to improve readability of the generated
todo list, a third command is introduced: bud. It simply resets to the
"onto" revision, i.e. the commit onto which we currently rebase.The code looks good, but I'm a little wary of adding bud which hard-codes a specific label. I suppose it does grant a bit of readability to the resulting script... ? It doesn't seem that important compared to use using "reset onto"? At least when documenting this it should be made clear that the "onto" label is special. Thanks, Jake.