Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once

On Tue, Oct 24, 2017 at 9:48 PM, Junio C Hamano [off-list ref] wrote:

Jeff King [off-list ref] writes:

quoted

I definitely agree with the sentiment that as few things as possible
should happen between calling getenv() and using its result. I've seen
real bugs there from unexpected invalidation of the static buffer.

Sure.  I do not think we mind xstrdup()ing the result and freeing
after we are done, though ;-)

More specifically, xstrdup_or_null(getenv(...)), if that route is chosen.