Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once
From: Junio C Hamano <hidden>
Date: 2017-10-25 01:48:16
Possibly related (same subject, not in this thread)
- 2017-10-25 · Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once · Andrey Okoshkin <hidden>
- 2017-10-25 · Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once · Andrey Okoshkin <hidden>
- 2017-10-25 · Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once · Andrey Okoshkin <hidden>
- 2017-10-24 · Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once · Jeff King <hidden>
- 2017-10-24 · Re: [PATCH] merge-recursive: check GIT_MERGE_VERBOSITY only once · Martin Ågren <hidden>
Jeff King [off-list ref] writes:
I definitely agree with the sentiment that as few things as possible should happen between calling getenv() and using its result. I've seen real bugs there from unexpected invalidation of the static buffer.
Sure. I do not think we mind xstrdup()ing the result and freeing after we are done, though ;-)