Thread (60 messages) flat view 60 messages, 6 authors, 2017-08-17

Re: [PATCH v3 2/5] interpret-trailers: add an option to show only the trailers

From: Jeff King <hidden>
Date: 2017-08-10 18:31:13

On Thu, Aug 10, 2017 at 11:28:52AM -0700, Stefan Beller wrote:
quoted
+test_expect_success 'only trailers' '
+       git config trailer.sign.command "echo config-value" &&
You may want to use 'test_config' here, which keeps the config
only for one test. The subsequent tests seem to overwrite the
config, so this is not wrong, just not the best style.
Yeah, I actually considered that but decided to keep style with the rest
of the script. I agree the whole thing could possibly switch to
test_config, but I suspect there may be some fallouts (the style of the
rest of the script seems to assume some continuity between the tests).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help