Re: [PATCH v7 1/2] exec_cmd: expose is_executable function

[PATCH 0/5] forking and threading · Brandon Williams <hidden> · 2017-04-10
[PATCH 1/5] run-command: convert sane_execvp to sane_execvpe · Brandon Williams <hidden> · 2017-04-10
Re: [PATCH 1/5] run-command: convert sane_execvp to sane_execvpe · Brandon Williams <hidden> · 2017-04-12
[PATCH 2/5] run-command: prepare argv before forking · Brandon Williams <hidden> · 2017-04-10
[PATCH 5/5] run-command: add note about forking and threading · Brandon Williams <hidden> · 2017-04-10
Re: [PATCH 5/5] run-command: add note about forking and threading · Jonathan Nieder <hidden> · 2017-04-11
Re: [PATCH 5/5] run-command: add note about forking and threading · Eric Wong <hidden> · 2017-04-11
Re: [PATCH 5/5] run-command: add note about forking and threading · Jonathan Nieder <hidden> · 2017-04-11
Re: [PATCH 5/5] run-command: add note about forking and threading · Brandon Williams <hidden> · 2017-04-11
Re: [PATCH 5/5] run-command: add note about forking and threading · Eric Wong <hidden> · 2017-04-11
[PATCH 4/5] run-command: prepare child environment before forking · Brandon Williams <hidden> · 2017-04-10
Re: [PATCH 4/5] run-command: prepare child environment before forking · Jonathan Nieder <hidden> · 2017-04-11
Re: [PATCH 4/5] run-command: prepare child environment before forking · Brandon Williams <hidden> · 2017-04-11
Re: [PATCH 4/5] run-command: prepare child environment before forking · Jonathan Nieder <hidden> · 2017-04-11
[PATCH 3/5] run-command: allocate child_err before forking · Brandon Williams <hidden> · 2017-04-10
[PATCH 6/5] run-command: avoid potential dangers in forked child · Eric Wong <hidden> · 2017-04-11
Re: [PATCH 6/5] run-command: avoid potential dangers in forked child · Brandon Williams <hidden> · 2017-04-11
Re: [PATCH 6/5] run-command: avoid potential dangers in forked child · Eric Wong <hidden> · 2017-04-11
Re: [PATCH 6/5] run-command: avoid potential dangers in forked child · Brandon Williams <hidden> · 2017-04-11
Re: [PATCH 0/5] forking and threading · Jonathan Nieder <hidden> · 2017-04-11
Re: [PATCH 0/5] forking and threading · Brandon Williams <hidden> · 2017-04-11
[PATCH v2 0/6] forking and threading · Brandon Williams <hidden> · 2017-04-13
[PATCH v2 4/6] run-command: don't die in child when duping /dev/null · Brandon Williams <hidden> · 2017-04-13
Re: [PATCH v2 4/6] run-command: don't die in child when duping /dev/null · Eric Wong <hidden> · 2017-04-13
Re: [PATCH v2 4/6] run-command: don't die in child when duping /dev/null · Brandon Williams <hidden> · 2017-04-13
[PATCH v2 1/6] t5550: use write_script to generate post-update hook · Brandon Williams <hidden> · 2017-04-13
Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook · Jonathan Nieder <hidden> · 2017-04-13
Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook · Eric Wong <hidden> · 2017-04-13
Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook · Brandon Williams <hidden> · 2017-04-13
Re: [PATCH v2 1/6] t5550: use write_script to generate post-update hook · Eric Wong <hidden> · 2017-04-13
[PATCH v2 5/6] run-command: eliminate calls to error handling functions in child · Brandon Williams <hidden> · 2017-04-13
[PATCH v2 2/6] run-command: prepare command before forking · Brandon Williams <hidden> · 2017-04-13
Re: [PATCH v2 2/6] run-command: prepare command before forking · Jonathan Nieder <hidden> · 2017-04-13
Re: [PATCH v2 2/6] run-command: prepare command before forking · Brandon Williams <hidden> · 2017-04-13
[PATCH v2 6/6] run-command: add note about forking and threading · Brandon Williams <hidden> · 2017-04-13
[PATCH v2 3/6] run-command: prepare child environment before forking · Brandon Williams <hidden> · 2017-04-13
Re: [PATCH v2 0/6] forking and threading · Jonathan Nieder <hidden> · 2017-04-13
Re: [PATCH v2 0/6] forking and threading · Brandon Williams <hidden> · 2017-04-13
[PATCH 7/6] run-command: block signals between fork and execve · Eric Wong <hidden> · 2017-04-13
Re: [PATCH 7/6] run-command: block signals between fork and execve · Brandon Williams <hidden> · 2017-04-13
Re: [PATCH 7/6] run-command: block signals between fork and execve · Brandon Williams <hidden> · 2017-04-14
Re: [PATCH 7/6] run-command: block signals between fork and execve · Eric Wong <hidden> · 2017-04-14
Re: [PATCH 7/6] run-command: block signals between fork and execve · Eric Wong <hidden> · 2017-04-14
[PATCH v3 00/10] forking and threading · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 01/10] t5550: use write_script to generate post-update hook · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 02/10] t0061: run_command executes scripts without a #! line · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 03/10] run-command: prepare command before forking · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 07/10] run-command: eliminate calls to error handling functions in child · Brandon Williams <hidden> · 2017-04-14
Re: [PATCH v3 07/10] run-command: eliminate calls to error handling functions in child · Eric Wong <hidden> · 2017-04-14
Re: [PATCH v3 07/10] run-command: eliminate calls to error handling functions in child · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 05/10] run-command: prepare child environment before forking · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 09/10] run-command: add note about forking and threading · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 08/10] run-command: handle dup2 and close errors in child · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 10/10] run-command: block signals between fork and execve · Brandon Williams <hidden> · 2017-04-14
Re: [PATCH v3 10/10] run-command: block signals between fork and execve · Brandon Williams <hidden> · 2017-04-14
Re: [PATCH v3 10/10] run-command: block signals between fork and execve · Eric Wong <hidden> · 2017-04-14
[PATCH v3 06/10] run-command: don't die in child when duping /dev/null · Brandon Williams <hidden> · 2017-04-14
Re: [PATCH v3 06/10] run-command: don't die in child when duping /dev/null · Eric Wong <hidden> · 2017-04-14
Re: [PATCH v3 06/10] run-command: don't die in child when duping /dev/null · Brandon Williams <hidden> · 2017-04-14
[PATCH v3 04/10] run-command: use the async-signal-safe execv instead of execvp · Brandon Williams <hidden> · 2017-04-14
[PATCH v4 00/10] forking and threading · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 01/10] t5550: use write_script to generate post-update hook · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 03/10] run-command: prepare command before forking · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 02/10] t0061: run_command executes scripts without a #! line · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 04/10] run-command: use the async-signal-safe execv instead of execvp · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 07/10] run-command: eliminate calls to error handling functions in child · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 06/10] run-command: don't die in child when duping /dev/null · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 10/10] run-command: block signals between fork and execve · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 09/10] run-command: add note about forking and threading · Brandon Williams <hidden> · 2017-04-17
[PATCH v4 05/10] run-command: prepare child environment before forking · Brandon Williams <hidden> · 2017-04-17
Re: [PATCH v4 05/10] run-command: prepare child environment before forking · Eric Wong <hidden> · 2017-04-18
Re: [PATCH v4 05/10] run-command: prepare child environment before forking · Brandon Williams <hidden> · 2017-04-18
[PATCH v4 08/10] run-command: handle dup2 and close errors in child · Brandon Williams <hidden> · 2017-04-17
[PATCH v5 00/11] forking and threading · Brandon Williams <hidden> · 2017-04-18
[PATCH v5 01/11] t5550: use write_script to generate post-update hook · Brandon Williams <hidden> · 2017-04-18
[PATCH v5 03/11] run-command: prepare command before forking · Brandon Williams <hidden> · 2017-04-18
[PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Brandon Williams <hidden> · 2017-04-18
Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Johannes Sixt <hidden> · 2017-04-19
Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Johannes Sixt <hidden> · 2017-04-19
Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Brandon Williams <hidden> · 2017-04-19
Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Johannes Sixt <hidden> · 2017-04-19
Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Johannes Schindelin <hidden> · 2017-04-20
Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Brandon Williams <hidden> · 2017-04-20
Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Johannes Schindelin <hidden> · 2017-04-20
Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line · Brandon Williams <hidden> · 2017-04-20
[PATCH v5 05/11] string-list: add string_list_remove function · Brandon Williams <hidden> · 2017-04-18
Re: [PATCH v5 05/11] string-list: add string_list_remove function · Stefan Beller <hidden> · 2017-04-18
Re: [PATCH v5 05/11] string-list: add string_list_remove function · Brandon Williams <hidden> · 2017-04-18
Re: [PATCH v5 05/11] string-list: add string_list_remove function · Stefan Beller <hidden> · 2017-04-18
[PATCH v5 07/11] run-command: don't die in child when duping /dev/null · Brandon Williams <hidden> · 2017-04-18
[PATCH v5 04/11] run-command: use the async-signal-safe execv instead of execvp · Brandon Williams <hidden> · 2017-04-18
[PATCH v5 08/11] run-command: eliminate calls to error handling functions in child · Brandon Williams <hidden> · 2017-04-18
[PATCH v5 10/11] run-command: add note about forking and threading · Brandon Williams <hidden> · 2017-04-18
[PATCH v5 09/11] run-command: handle dup2 and close errors in child · Brandon Williams <hidden> · 2017-04-18
[PATCH v5 11/11] run-command: block signals between fork and execve · Brandon Williams <hidden> · 2017-04-18
Re: [PATCH v5 11/11] run-command: block signals between fork and execve · Johannes Sixt <hidden> · 2017-04-19
Re: [PATCH v5 11/11] run-command: block signals between fork and execve · Eric Wong <hidden> · 2017-04-19
Re: [PATCH v5 11/11] run-command: block signals between fork and execve · Brandon Williams <hidden> · 2017-04-19
[PATCH v5 06/11] run-command: prepare child environment before forking · Brandon Williams <hidden> · 2017-04-18
[PATCH v6 00/11] forking and threading · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 01/11] t5550: use write_script to generate post-update hook · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 02/11] t0061: run_command executes scripts without a #! line · Brandon Williams <hidden> · 2017-04-19
Re: [PATCH v6 02/11] t0061: run_command executes scripts without a #! line · Johannes Schindelin <hidden> · 2017-04-20
Re: [PATCH v6 02/11] t0061: run_command executes scripts without a #! line · Brandon Williams <hidden> · 2017-04-20
[PATCH v6 04/11] run-command: use the async-signal-safe execv instead of execvp · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 05/11] string-list: add string_list_remove function · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 08/11] run-command: eliminate calls to error handling functions in child · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 06/11] run-command: prepare child environment before forking · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 03/11] run-command: prepare command before forking · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 07/11] run-command: don't die in child when duping /dev/null · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 09/11] run-command: handle dup2 and close errors in child · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 10/11] run-command: add note about forking and threading · Brandon Williams <hidden> · 2017-04-19
[PATCH v6 11/11] run-command: block signals between fork and execve · Brandon Williams <hidden> · 2017-04-19
Re: [PATCH v6 00/11] forking and threading · Brandon Williams <hidden> · 2017-04-24
[PATCH v6 12/11] run-command: don't try to execute directories · Brandon Williams <hidden> · 2017-04-24
Re: [PATCH v6 12/11] run-command: don't try to execute directories · Jonathan Nieder <hidden> · 2017-04-25
Re: [PATCH v6 12/11] run-command: don't try to execute directories · Jeff King <hidden> · 2017-04-25
Re: [PATCH v6 12/11] run-command: don't try to execute directories · Jonathan Nieder <hidden> · 2017-04-25
[PATCH v7 1/2] exec_cmd: expose is_executable function · Brandon Williams <hidden> · 2017-04-25
[PATCH v7 2/2] run-command: don't try to execute directories · Brandon Williams <hidden> · 2017-04-25
Re: [PATCH v7 2/2] run-command: don't try to execute directories · Jonathan Nieder <hidden> · 2017-04-25
Re: [PATCH v7 2/2] run-command: don't try to execute directories · Brandon Williams <hidden> · 2017-04-25
Re: [PATCH v7 1/2] exec_cmd: expose is_executable function · Jonathan Nieder <hidden> · 2017-04-25
Re: [PATCH v7 1/2] exec_cmd: expose is_executable function · Johannes Sixt <hidden> · 2017-04-25
Re: [PATCH v7 1/2] exec_cmd: expose is_executable function · Brandon Williams <hidden> · 2017-04-25
[PATCH v8 1/2] run-command: expose is_executable function · Brandon Williams <hidden> · 2017-04-25
[PATCH v8 2/2] run-command: restrict PATH search to executable files · Brandon Williams <hidden> · 2017-04-25
Re: [PATCH v8 2/2] run-command: restrict PATH search to executable files · Jonathan Nieder <hidden> · 2017-04-25
Re: [PATCH v8 1/2] run-command: expose is_executable function · Jonathan Nieder <hidden> · 2017-04-25

From: Johannes Sixt <hidden>
Date: 2017-04-25 18:18:16

Am 25.04.2017 um 19:54 schrieb Brandon Williams:

Move the logic for 'is_executable()' from help.c to exec_cmd.c and
expose it so that callers from outside help.c can access the function.

The function is quite low-level. IMO, run-command.[ch] would be a better 
home for it. Additionally, that would reduce the number of files that 
contain #ifdef GIT_WINDOWS_NATIVE.

-- Hannes

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help