Thread (129 messages) 129 messages, 7 authors, 2017-04-25

Re: [PATCH v5 02/11] t0061: run_command executes scripts without a #! line

From: Brandon Williams <hidden>
Date: 2017-04-19 15:57:09

On 04/19, Johannes Sixt wrote:
Am 19.04.2017 um 07:43 schrieb Johannes Sixt:
quoted
Am 19.04.2017 um 01:17 schrieb Brandon Williams:
quoted
Add a test to 't0061-run-command.sh' to ensure that run_command can
continue to execute scripts which don't include a '#!' line.
Why is this necessary? I am pretty certain that our emulation layer on
Windows can only run scripts with a shbang line.
Out of curiosity how did you have t5550 passing on windows then?  Since
the first patch in this series fixes a that test which doesn't have a
'#!' line.
Nevermind. It is a compatibility feature: People may have written
their hooks and scripts without #!, and these must continue to work
where they worked before.

Please protect the new test with !MINGW.
Will do.
Thanks,
-- Hannes
-- 
Brandon Williams
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help