Thread (129 messages) 129 messages, 7 authors, 2017-04-25

Re: [PATCH v6 02/11] t0061: run_command executes scripts without a #! line

From: Brandon Williams <hidden>
Date: 2017-04-20 16:58:33

On 04/20, Johannes Schindelin wrote:
Hi Brandon,

On Wed, 19 Apr 2017, Brandon Williams wrote:
quoted
Add a test to 't0061-run-command.sh' to ensure that run_command can
continue to execute scripts which don't include a '#!' line.

Signed-off-by: Brandon Williams <redacted>
Please add something like this to the commit message lest future readers
wonder where that !MINGW comes from:

	On Windows, shell scripts are not natively executable. Git has a
	workaround to execute them, looking for the shebang line. Shell
	scripts without a shebang line will simply not execute on Windows.
	Therefore, disable the new test on Windows.
I'm fine with including this in the commit message.  If another reroll
needs to happen then I can make the update otherwise hopefully Junio can
just squash that in.
Thanks,
Dscho
-- 
Brandon Williams
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help