Thread (234 messages) flat view 234 messages, 5 authors, 2017-04-07

Re: [PATCH v4 11/15] refs.c: make get_main_ref_store() public and use it

From: Michael Haggerty <hidden>
Date: 2017-02-20 12:40:20

On 02/18/2017 02:32 PM, Nguyễn Thái Ngọc Duy wrote:
get_ref_store() will soon be renamed to get_submodule_ref_store().
Together with future get_worktree_ref_store(), the three functions
provide an appropriate ref store for different operation modes. New APIs
will be added to operate directly on ref stores.
I see where you're going with this, but as of the end of this patch
series, there is still nothing that a caller outside of the refs module
can do with a `struct ref_store *`. This means that it would be enough
to put this declaration (and that of `get_submodule_ref_store()`, added
in a later patch) in refs/refs-internal.h for now.

If you want to move the declarations straight to `refs.h` now to avoid
code churn in some later patch series, then please mention that fact in
the commit message.

Michael
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help