Thread (234 messages) flat view 234 messages, 5 authors, 2017-04-07

Re: [PATCH 06/11] refs-internal.h: correct is_per_worktree_ref()

From: Stefan Beller <hidden>
Date: 2017-02-13 22:38:04

On Mon, Feb 13, 2017 at 7:20 AM, Nguyễn Thái Ngọc Duy [off-list ref] wrote:
quoted hunk ↗ jump to hunk
All refs outside refs/ directory is per-worktree, not just HEAD.

Signed-off-by: Nguyễn Thái Ngọc Duy <redacted>
---
 refs/refs-internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index f4aed49f5..69d02b6ba 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -653,7 +653,7 @@ const char *resolve_ref_recursively(struct ref_store *refs,

 static inline int is_per_worktree_ref(const char *refname)
 {
-       return !strcmp(refname, "HEAD") ||
+       return !starts_with(refname, "refs/") ||
                starts_with(refname, "refs/bisect/");
you're loosing HEAD here? (assuming we get HEAD in
short form here, as well as long form refs/HEAD)
 }

--
2.11.0.157.gd943d85
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help