Re: [PATCH v7 10/17] ref-filter: introduce refname_atom_parser_internal()

On Sat, Nov 19, 2016 at 3:06 AM, Jakub Narębski [off-list ref] wrote:

W dniu 08.11.2016 o 21:12, Karthik Nayak pisze:

quoted

From: Karthik Nayak <redacted>

Since there are multiple atoms which print refs ('%(refname)',
'%(symref)', '%(push)', '%upstream'), it makes sense to have a common

Minor typo; it should be: "%(upstream)"

Will fix that.

quoted

ground for parsing them. This would allow us to share implementations of
the atom modifiers between these atoms.

Introduce refname_atom_parser_internal() to act as a common parsing
function for ref printing atoms. This would eventually be used to
introduce refname_atom_parser() and symref_atom_parser() and also be
internally used in remote_ref_atom_parser().

Helped-by: Jeff King [off-list ref]
Signed-off-by: Karthik Nayak <redacted>
---

[...]

quoted

+static void refname_atom_parser_internal(struct refname_atom *atom,
+                                      const char *arg, const char *name)
+{
+     if (!arg)
+             atom->option = R_NORMAL;
+     else if (!strcmp(arg, "short"))
+             atom->option = R_SHORT;
+     else if (skip_prefix(arg, "strip=", &arg)) {
+             atom->option = R_STRIP;
+             if (strtoul_ui(arg, 10, &atom->strip) || atom->strip <= 0)
+                     die(_("positive value expected refname:strip=%s"), arg);
+     }       else

          ^^^^^^

It looks like you have spurious tab here.

That would have gone unnoticed, thanks for pointing it out.

-- 
Regards,
Karthik Nayak