Thread (57 messages) flat view 57 messages, 3 authors, 2016-11-20

Re: [PATCH v7 15/17] branch, tag: use porcelain output

From: Jacob Keller <hidden>
Date: 2016-11-09 00:01:49

On Tue, Nov 8, 2016 at 12:12 PM, Karthik Nayak [off-list ref] wrote:
From: Karthik Nayak <redacted>

Call ref-filter's setup_ref_filter_porcelain_msg() to enable
translated messages for the %(upstream:tack) atom. Although branch.c
doesn't currently use ref-filter's printing API's, this will ensure
that when it does in the future patches, we do not need to worry about
translation.
Makes sense.

Thanks,
Jake
quoted hunk ↗ jump to hunk
Written-by: Matthieu Moy [off-list ref]
Mentored-by: Christian Couder [off-list ref]
Mentored-by: Matthieu Moy [off-list ref]
Signed-off-by: Karthik Nayak <redacted>
---
 builtin/branch.c | 2 ++
 builtin/tag.c    | 2 ++
 2 files changed, 4 insertions(+)
diff --git a/builtin/branch.c b/builtin/branch.c
index be9773a..dead2b8 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -656,6 +656,8 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
                OPT_END(),
        };

+       setup_ref_filter_porcelain_msg();
+
        memset(&filter, 0, sizeof(filter));
        filter.kind = FILTER_REFS_BRANCHES;
        filter.abbrev = -1;
diff --git a/builtin/tag.c b/builtin/tag.c
index 50e4ae5..a00e9a7 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -373,6 +373,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
                OPT_END()
        };

+       setup_ref_filter_porcelain_msg();
+
        git_config(git_tag_config, sorting_tail);

        memset(&opt, 0, sizeof(opt));
--
2.10.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help